Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Revert tab container upgrade" (#2855) #2909

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

camertron
Copy link
Contributor

This reverts commit 05159ca.

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Unfortunately the upgrade to tab-container-element has proven much more difficult than originally anticipated and has caused several dotcom rollbacks and bugs. This PR reverts the tab container upgrade to the previous version.

Screenshots

Integration

No changes necessary in production.

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: b131354

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review June 21, 2024 16:47
@camertron camertron requested review from a team as code owners June 21, 2024 16:47
@camertron camertron requested review from lukasoppermann and TylerJDev and removed request for a team June 21, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants