feat: add asImageSrc, asImageWidthSrcSet, asImagePixelDensitySrcSet
#38
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 13 +3
Lines 154 188 +34
Branches 30 39 +9
=========================================
+ Hits 154 188 +34
Continue to review full report at Codecov.
|
angeloashmore
changed the title
asImageSrc, asImageWidthSrcSet, asImagePixelDensitiesSrcSetasImageSrc, asImageWidthSrcSet, asImagePixelDensitySrcSet
size-limit report 📦
|
| field: Field, | ||
| params: ImgixURLParams = {}, | ||
| ): AsImageSrcReturnType<Field> => { | ||
| if (isImageThumbnailFilled(field)) { |
There was a problem hiding this comment.
Side note but we should at some point update the other helpers to use those isFilled() functions too, great move!
…responsive views
|
@lihbr The PR has been updated per your review. Could you take a look at the two remaining comments? (Excuse the messy commit log. We'll squash this one. I was having trouble getting AVA 4 working and ended up reverting to AVA 3 instead… :/) |
|
No worries ^^ Happens to me everyday~ Looking sharp! Let's just trim down the responsive sizes to the list of 5 and we're good :) |
Types of changes
Description
This PR adds the following image helpers:
asImageSrc: Converts an Image field to an image URL with optional image transformations (via Imgix).asImageWidthSrcSet: Converts an Image field to a width-basedsrcsetstring.asImagePixelDensitySrcSet: Converts an Image field to a pixel-density-basedsrcsetstring.For more background on the need for and implementation of these helpers, see #37.
Checklist:
🐮