Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add middleware check_witness #356

Merged
merged 3 commits into from
Sep 16, 2024
Merged

feat: add middleware check_witness #356

merged 3 commits into from
Sep 16, 2024

Conversation

ed255
Copy link
Member

@ed255 ed255 commented Jun 21, 2024

Complete the implementation of the check_witness function which checks that a witness assignment passes all the constraints from a middleware Circuit. The missing parts were:

  • Simulate blind rows
  • Check copy constraints
  • Check lookups
  • Check shuffles

I've tried to keep the implementation simple (compared to the MockProver). For now it panics instead of returning errors.

This function was previously defined in the p3_frontend but is now moved to halo2_debug so that it can be used anywhere.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 59.52381% with 51 lines in your changes missing coverage. Please review.

Project coverage is 82.48%. Comparing base (bc857a7) to head (da4983e).

Files Patch % Lines
halo2_debug/src/check_witness.rs 58.19% 51 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   82.64%   82.48%   -0.17%     
==========================================
  Files          84       85       +1     
  Lines       17750    17832      +82     
==========================================
+ Hits        14670    14709      +39     
- Misses       3080     3123      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@guorong009 guorong009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidnevadoc davidnevadoc merged commit c84fbb8 into main Sep 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants