This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GethClient and support for minimum required JSON-RPC endpoints by bus-mapping. #171
Add GethClient and support for minimum required JSON-RPC endpoints by bus-mapping. #171
Changes from all commits
043b038
a81c2f3
b6cdf43
ec5f10b
c5f501c
126b87e
e6a7c7a
85a63dd
868ca72
7cf0c52
c8f9513
5610420
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW we'd be happy to upstream the Geth Tracing logic to ethers-rs, similar to the parity tracing module https://github.com/gakonst/ethers-rs/blob/master/ethers-providers/src/provider.rs#L788
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that we use a slightly different variant of the types that you have defined in your lib.
That's why we did not make a PR adding them in
ethers
and instead just took theProvider
backend and used it directly.Will try to add this in a PR in ethers once I get a bit more time :)