Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

fix typos #1788

Closed
wants to merge 1 commit into from
Closed

fix typos #1788

wants to merge 1 commit into from

Conversation

miles-six
Copy link

@miles-six miles-six commented Mar 8, 2024 •
edited
Loading

Description

[Fix typos_]

Issue Link

[No]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor (no updates to logic)

description

I have been studying this repository for a long time, and I discovered 6 typos in a total of 5 files. Then I merged them together.

The code quality is exceptionally high, so sincerely hope my PR can help make this repository more standardized.

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-eth-types Issues related to the eth-types workspace member labels Mar 8, 2024
hero78119
hero78119 suggested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution.

There is good first issue #1781 issue to add this typo detection on CI. Will be appreciated if you take over this issue and expand scope of PR

@miles-six miles-six closed this by deleting the head repository Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hero78119 hero78119 hero78119 requested changes

Assignees
No one assigned
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member crate-eth-types Issues related to the eth-types workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miles-six @hero78119