-
Notifications
You must be signed in to change notification settings - Fork 854
Add dummy_gen_create_ops
to avoid call stack empty panic
#454
Add dummy_gen_create_ops
to avoid call stack empty panic
#454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Nevertheless, please take a look at how push_op_reversible
already applies the write operations to the StateDB (and thus there's no need to do it before). For context, this change was done here https://github.com/appliedzkp/zkevm-circuits/pull/436/files#diff-a06662ad93069ff8d12d1029c92dd22ef395882417fc8daa8a292f582eded9deR812
c10b991
to
1536b64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
8e26eda
to
d43c6d8
Compare
Just rebased and I think this is ready to be merged! Should we merge @han0110 ? Or is there anything left you want to do? |
Nothing left to do, let's merge it after CI is finished. Thanks! |
This PR aims to make
CircuitInputBuilder
work with trace containingCREATE*
bydummy_gen_create_ops
, which takes care of call stack and state db to enable the parsing.It also does:
Memory::read_word
to be able to read a word even thememory[offset..offset+32]
is out of range (the same behavior of EVM), and we would want this behavior because the step of trace has the memory before expansion.dummy_gen_selfdestructed_op
.With #440 implemented, we should be able create partially verified proof of all kinds of trace (hopefully) instead of panic.