Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video frontend Revamp #274

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Video frontend Revamp #274

merged 1 commit into from
Nov 18, 2021

Conversation

TommyTran732
Copy link
Contributor

The video page is extremely wrong and broken right now:

  • Being decentralized doesn't mean it's private, it's more for censorship resistance
  • Your IP is still visible to the individous instance, and its not like they will even proxy you by default
  • Broken link

This page is so much of a mess that it needs to be completely redone, and I don't think keeping it is a good idea considering it's a legacy page. We will make a new page recommending things like Newpipe/Freetube later using the new system.

@dngray
Copy link
Member

dngray commented Nov 10, 2021

I do agree with re-working the page and recommending things like Newpipe/Freetube.

@TommyTran732
Copy link
Contributor Author

Oh dear, I need to fix the PR

@Mikaela Mikaela added the c:providers service providers and similar centralized/federated services label Nov 11, 2021
@netlify
Copy link

netlify bot commented Nov 14, 2021

✔️ Deploy Preview for privacyguides ready!

🔨 Explore the source changes: 253bf5e

🔍 Inspect the deploy log: https://app.netlify.com/sites/privacyguides/deploys/61960108ec486b0008d2b721

😎 Browse the preview: https://deploy-preview-274--privacyguides.netlify.app/video-streaming

@TommyTran732 TommyTran732 changed the title Video frontend removal (WIP Video frontend Revamp) Nov 17, 2021
@TommyTran732 TommyTran732 changed the title (WIP Video frontend Revamp) (WIP) Video frontend Revamp Nov 17, 2021
@TommyTran732 TommyTran732 changed the title (WIP) Video frontend Revamp Video frontend Revamp Nov 17, 2021
@TommyTran732
Copy link
Contributor Author

TommyTran732 commented Nov 18, 2021

@dngray

This PR is ready for merge. It also fixes #334

PeerTube is not mentioned as I cannot find how you can have a private subscription list with it. It just looks like Youtube, but federated. You still need to sign up for an account with an instance and what not.

LBRY is a much better alternative as it stores the subscription list on your local LBRY wallet.

@dngray dngray requested review from a team, freddy-m, Mikaela and dngray and removed request for a team, freddy-m and Mikaela November 18, 2021 07:19
Co-authored-by: Daniel Nathan Gray <dng@disroot.org>
@dngray dngray merged commit 253bf5e into privacyguides:main Nov 18, 2021
@dngray dngray temporarily deployed to production November 18, 2021 07:36 Inactive
dngray added a commit that referenced this pull request Nov 20, 2021
Co-authored-by: Daniel Nathan Gray <dng@disroot.org>
dngray added a commit that referenced this pull request Nov 20, 2021
Co-authored-by: Daniel Nathan Gray <dng@disroot.org>
@ItsIgnacioPortal
Copy link

ItsIgnacioPortal commented Nov 21, 2021

This page is so much of a mess that it needs to be completely redone, and I don't think keeping it is a good idea considering it's a legacy page. We will make a new page recommending things like Newpipe/Freetube later using the new system.

This addition should've been on this same PR before it was merged into main. Pushing incomplete contributions into main, defeats the purpose of stable-branches.

Some people were confused by this, so please try to avoid it in the future

@dngray
Copy link
Member

dngray commented Nov 30, 2021

Some people were confused by this, so please try to avoid it in the future

Regarding this post specifically. I'll post my reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:providers service providers and similar centralized/federated services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants