Skip to content

Commit

Permalink
Merge pull request #201 from privatenumber/develop
Browse files Browse the repository at this point in the history
  • Loading branch information
privatenumber committed Aug 19, 2021
2 parents e714b93 + 06c1cac commit db0971c
Show file tree
Hide file tree
Showing 7 changed files with 185 additions and 103 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,6 @@ If you're not using TypeScript, JSX, or any syntax unsupported by Webpack, you c

There are two ways to minify CSS, depending on your setup. You should already have CSS setup in your build using [`css-loader`](https://github.com/webpack-contrib/css-loader).

⚠️ esbuild currently [doesn't support source-maps for CSS minification](https://github.com/evanw/esbuild/issues/519).

#### CSS assets
If your CSS is extracted and emitted as a CSS file, you can replace CSS minification plugins like [`css-minimizer-webpack-plugin`](https://github.com/webpack-contrib/css-minimizer-webpack-plugin) or [`optimize-css-assets-webpack-plugin`](https://github.com/NMFR/optimize-css-assets-webpack-plugin) with the same `ESBuildMinifyPlugin` by enabling the `css` option.

Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"webpack": "^4.40.0 || ^5.0.0"
},
"dependencies": {
"esbuild": "^0.12.19",
"esbuild": "^0.12.21",
"joycon": "^3.0.1",
"json5": "^2.2.0",
"loader-utils": "^2.0.0",
Expand All @@ -49,8 +49,8 @@
"webpack-sources": "^2.2.0"
},
"devDependencies": {
"@pvtnbr/eslint-config-typescript": "^0.1.19",
"@types/jest": "^27.0.0",
"@pvtnbr/eslint-config-typescript": "^0.1.22",
"@types/jest": "^27.0.1",
"@types/loader-utils": "^2.0.3",
"@types/webpack": "^4.41.30",
"css-loader": "^5.2.0",
Expand Down
Loading

0 comments on commit db0971c

Please sign in to comment.