Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade esbuild #211

Merged
merged 1 commit into from
Oct 8, 2021
Merged

feat: upgrade esbuild #211

merged 1 commit into from
Oct 8, 2021

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Oct 8, 2021

I wish "esbuild" can be a peer dependency, which will allow users to upgrade by themselves.

@privatenumber
Copy link
Owner

@g-plane
Copy link
Contributor Author

g-plane commented Oct 8, 2021

I know, but I don't think that will prevent this PR.

@privatenumber
Copy link
Owner

Why's that?

@g-plane
Copy link
Contributor Author

g-plane commented Oct 8, 2021

That will require additional configurations, which most people won't notice that. Also, that will introduce two or more "esbuild" installations in node_modules directory.

@privatenumber
Copy link
Owner

If those are the only motivations you have to make this PR, I think it's preventable.

Majority of users don't care about using the latest esbuild; they're just happy with the speed benefits. Amongst those that do care, the majority are happy with the implementation API. It's rare that someone feels compelled by a package duplication in node_modules.

JSYK I understand the benefits of having it as a peer dependency, and it will be in the future. In case you missed it in the readme:

The implementation option will be removed once esbuild reaches a stable release. Instead esbuild will become a peerDependency so you always provide your own.

Currently, the maintenance cost I would take by expecting users to understand npm's major-zero semver and how it's different from normal semver is too high. Having this road-block actually saves me time at a small cost to the API.

@vgpechenkin
Copy link

vgpechenkin commented Oct 8, 2021

Hi,
I try to use custom esbuild (0.13.x version). But on CI I have a problem with downloading platform-specific version esbuild (#206).
It has been fixed in 0.13 version.
Thanks

@privatenumber
Copy link
Owner

That's a good motivation. Thanks for sharing it!

Will try to release tomorrow. Sorry, its late here.

(Don't hesitate to request an upgrade in the future, especially if theres a problem. I'm not against it, just busy.)

@privatenumber privatenumber changed the title chore: upgrade esbuild feat: upgrade esbuild Oct 8, 2021
@privatenumber privatenumber merged commit 1525506 into privatenumber:develop Oct 8, 2021
privatenumber pushed a commit that referenced this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants