Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade esbuild to 0.14.39 #245

Merged
merged 2 commits into from
May 15, 2022
Merged

feat: upgrade esbuild to 0.14.39 #245

merged 2 commits into from
May 15, 2022

Conversation

piggynl
Copy link
Contributor

@piggynl piggynl commented Mar 18, 2022

esbuild added support for riscv64 architecture in 0.14.22 and the latest version of esbuild is 0.14.27 now.

@piggynl
Copy link
Contributor Author

piggynl commented Mar 18, 2022

Hi. it seems esbuild generates different code compared with the previous version. For example:

- var f = Object.create(null);
+ var f = /* @__PURE__ */ Object.create(null);

- typeof Symbol!="undefined"
+ typeof Symbol<"u" 

- const e=1;export default e;
+ const e=1;export default 1;

Shall I update minify.test.ts.snap and minify.test.ts to pass the test?

@privatenumber
Copy link
Owner

Yeah, the snapshots should update with: npm test -- -u

@privatenumber privatenumber changed the title feat: upgrade esbuild to 0.14.27 feat: upgrade esbuild to 0.14.39 May 15, 2022
@privatenumber privatenumber merged commit a3ef769 into privatenumber:develop May 15, 2022
@privatenumber
Copy link
Owner

🎉 This PR is included in version 2.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@piggynl
Copy link
Contributor Author

piggynl commented May 16, 2022

Thank you very much!

@piggynl piggynl deleted the esbuild-0.14.27 branch May 16, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants