Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS/ECR public/private support #793

Merged
merged 1 commit into from
Nov 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 48 additions & 2 deletions .github/workflows/flowzone.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 25 additions & 2 deletions flowzone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,20 @@
# so this will fail for external PRs as the automatic actions token will be read-only
password: ${{ secrets.GITHUB_TOKEN }}

- &loginWithECRPublic
name: Login to AWS/ECR (public)
continue-on-error: true
uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0
with:
registry: public.ecr.aws

- &loginWithECRPrivate
name: Login to AWS/ECR (private)
continue-on-error: true
uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0
with:
registry: ${{ matrix.image }}

- &customWorkingDirectory
defaults:
run:
Expand Down Expand Up @@ -420,7 +434,7 @@
github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.full_name != github.repository
run: |
echo "::error::External workflows can not be used with `pull_request` events. \
echo "::error::External workflows can not be used with 'pull_request' events. \
Please contact a member of the organization for assistance."
exit 1

Expand All @@ -430,7 +444,7 @@
github.event_name == 'pull_request_target' &&
github.event.pull_request.head.repo.full_name == github.repository
run: |
echo "::error::Internal workflows should not be used with `pull_request_target` events. \
echo "::error::Internal workflows should not be used with 'pull_request_target' events. \
Please consult the documentation for more information."
exit 1

Expand Down Expand Up @@ -557,6 +571,7 @@

- &getAWSCallerIdentity
name: Get caller identity (AWS/whoami)
continue-on-error: true
run: aws sts get-caller-identity

- &updateKubeconfig
Expand Down Expand Up @@ -2409,6 +2424,10 @@ jobs:

- *loginWithGitHubContainerRegistry
- *loginWithDockerHub
- *configureAWSCredentials
- *getAWSCallerIdentity
- *loginWithECRPublic
- *loginWithECRPrivate

# https://github.com/akhilerm/tag-push-action
- name: Publish manifest to remote(s)
Expand Down Expand Up @@ -2479,6 +2498,10 @@ jobs:
- *setupCrane
- *loginWithGitHubContainerRegistry
- *loginWithDockerHub
- *configureAWSCredentials
- *getAWSCallerIdentity
- *loginWithECRPublic
- *loginWithECRPrivate

# https://github.com/akhilerm/tag-push-action
- name: Publish final tags
Expand Down
Loading