Merge pull request #73 from projectdiscovery/feat/catch-ListenAndServ…

…e-error

feat: catch `http.ListenAndServe` error

clistats.go

@@ -187,9 +187,24 @@ func (s *Statistics) Start() error {
 			Handler: mux,
 		}
 
+		errChan := make(chan error, 1)
+		var done atomic.Bool
+
 		go func() {
-			_ = s.httpServer.ListenAndServe()
+			if err := s.httpServer.ListenAndServe(); err != nil && err != http.ErrServerClosed && !done.Load() {
+				errChan <- err
+			}
 		}()
+
+		// catch initial fatal errors
+		select {
+		case err := <-errChan:
+			return err
+		case <-time.After(250 * time.Millisecond):
+			done.Store(true)
+			close(errChan)
+		}
+
 	}
 	return nil
 }

clistats_test.go

@@ -51,3 +51,21 @@ func TestStartMultipleTimes(t *testing.T) {
 		require.Nil(t, err)
 	}
 }
+
+func TestStartMultipleTimesWithoutStopping(t *testing.T) {
+	client, err := New()
+	require.Nil(t, err)
+
+	for i := 1; i <= 2; i++ {
+		err = client.Start()
+
+		if i == 1 {
+			require.Nil(t, err)
+		} else {
+			require.NotNil(t, err)
+		}
+	}
+
+	err = client.Stop()
+	require.Nil(t, err)
+}