Make GIS models testable and test in CI #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use relative imports in all models. This way models can be ran from different locations, which will help with testing them.
Co-Authored-By: rht <rhtbot@protonmail.com>
- Rename workflow - Run on each push (which allows developing on test branches in this repo) - Run only on changes to the example models, the test script or the CI config - Allow multiple commits after each other (to allow continuous trial and error
|
PR is ready for review, all the CI and test code works as intended. Some model example tests fail, and I will fix the most obvious ones, but all others can be fixed in separate PRs. |
rht
reviewed
Aug 25, 2024
| @@ -48,7 +40,7 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| pip install mesa --pre | |||
| pip install pytest | |||
| pip install .[test] | |||
There was a problem hiding this comment.
Reminder to use uv later in a separate PR.
rht
reviewed
Aug 25, 2024
| - cron: '0 6 * * 1' # Monday at 6:00 UTC | ||
|
|
||
| jobs: | ||
| # build-stable: |
There was a problem hiding this comment.
Good question. I think we will want to make a backport to the mesa-2.x branch with examples, since Mesa-Geo is meant to work with Mesa 2.3.
So then we will make te split of testing pre-releases + git on the main branch, and stable on the Mesa-Geo 0.8.x branch.
rht
approved these changes
Aug 25, 2024
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables testing all GIS models with pytest, just like we do with our regular models (see #65 and #82). This includes a new
test_gis_examples.pythat allows running the tests locally, and is also used in the CI.Checklist
pyproject.toml.pyfile changes ingisfolderCurrently a lot of the example models still fail on various issues with the specific model. Help is very much wanted!