Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

Add streaming gateway list and status commands #202

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

scothis
Copy link
Member

@scothis scothis commented Jan 30, 2020

The gateway resource is typically controlled and should not be managed,
but we can observe it.

Resolves #201

The gateway resource is typically controlled and should not be managed,
but we can observe it.

Resolves projectriff#201
@scothis scothis requested a review from trisberg January 30, 2020 23:34
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #202 into master will increase coverage by 0.04%.
The diff coverage is 98.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   96.34%   96.38%   +0.04%     
==========================================
  Files          97      100       +3     
  Lines        4704     4818     +114     
==========================================
+ Hits         4532     4644     +112     
- Misses        135      136       +1     
- Partials       37       38       +1
Impacted Files Coverage Δ
pkg/streaming/commands/gateway_status.go 100% <100%> (ø)
pkg/streaming/commands/gateway.go 100% <100%> (ø)
pkg/streaming/commands/streaming.go 100% <100%> (ø) ⬆️
pkg/streaming/commands/inmemorygateway.go 100% <100%> (ø) ⬆️
pkg/streaming/commands/gateway_list.go 96.87% <96.87%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4569967...a4875e2. Read the comment docs.

Copy link
Member

@trisberg trisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scothis scothis merged commit c49d1f7 into projectriff:master Jan 31, 2020
@scothis scothis deleted the gateway-list branch January 31, 2020 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "riff streaming gateway list" command
2 participants