Change scrape_duration_seconds to gauge #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, the bucket gets configured by the user and not by us? Reading up on https://prometheus.io/docs/practices/histograms/ |
|
This should be a gauge, which contains the information for that scrape. This was fixed a while back on the node exporter, I'm guessing this was copied from before then. |
… split out collector_success
carlpett
force-pushed
the
histogram-durations
branch
from
f57ebfe
to
56a3ca2
Compare
carlpett
changed the title
|
@brian-brazil Ah, that makes sense. Yes, the summary is probably from the initial commit, more or less. |
brian-brazil
reviewed
Jul 5, 2017
exporter.go
Outdated
|
|
||
| if err != nil { | ||
| log.Errorf("ERROR: %s collector failed after %fs: %s", name, duration.Seconds(), err) | ||
| result = "error" | ||
| scrapeSuccess.WithLabelValues(name).Set(0) |
There was a problem hiding this comment.
This should use ConstMetrics, so there's no interference from any scrapes happening at the same time
carlpett
force-pushed
the
histogram-durations
branch
from
49c11ee
to
9ba762e
Compare
|
👍 |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
scrape_duration_secondsmetric is a summary. When trying to reason about #89, it is hard to look back in time to see if others have this problem as well, since we do not have the buckets. I see no real benefit in using a summary here, and think we should be using a histogram instead.Probably we should be setting the
Bucketsoption as well, rather than using the defaults. My lowest 0.5 quantile with the current summary is ~0.04s, so I would make an initial guess that something like[0.01, 0.015, 0.03, 0.1, 0.15, 0.3, 1.0, 3.0, Inf]would capture the interesting ranges with acceptable precision?