Initial work on OpenMetrics #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-brazil
force-pushed
the
openmetrics
branch
from
40eea3c
to
b1b80f2
Compare
SuperQ
reviewed
Aug 29, 2018
brian-brazil
force-pushed
the
openmetrics
branch
from
f9e6017
to
bdceab0
Compare
SuperQ
approved these changes
Sep 7, 2018
brian-brazil
force-pushed
the
openmetrics
branch
from
bdceab0
to
df22348
Compare
With OpenMetrics the _total is a suffix on a sample for a counter, so the convention that Counters should end in total is now enforced. If an existing counter is missing the _total, it'll now appear on the /metrics. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
This makes things more structured and readable, and allows for extra information OpenMetrics will need. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Add support for this in Prometheus text format exposition Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
If unit is missing add it rather than erroring. Add unit support to core types. Don't allow unit on info/stateset/enum, as that doesn't make sense. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
It's only in the timeseries name now. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil
force-pushed
the
openmetrics
branch
from
df22348
to
eb4ac52
Compare
|
Do you know when Info and Enum metrics will be available? |
|
Whenever the next release is, there's more work to be done. You can already emulate them yourself with gauges. |
6 tasks
yurishkuro
pushed a commit
to jaegertracing/jaeger-client-python
that referenced
this pull request
Sep 7, 2021
The tests must be adapeted due prometheus/client_python#300 Signed-off-by: Kai Mueller <15907922+kasium@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle all valid inputs, but does not yet reject all invalid inputs.