feat(encoding): add functions for individually encoding registry & EOF #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrone-wu
force-pushed
the
feat/encode-registry-and-eof
branch
2 times, most recently
from
86d81e1
to
b643b2e
Compare
mxinden
reviewed
Jul 1, 2024
All credits on the initial idea, implementation, and testing belong to @amunra, who is the original author of this PR prometheus#154. From the original PR description: Adds new `encode_registry` and `encode_eof` functions to allow encoding of parts of the response. This is useful when there are multiple registries at play, or when composing metrics for a process that embeds Rust as part of its logic whilst serving metrics to Prometheus outside of Rust. Fixes: prometheus#153 Refs: prometheus#154, prometheus#204 Co-authored-by: amunra <cimarosti@gmail.com> Signed-off-by: tyrone-wu <wudevelops@gmail.com>
tyrone-wu
force-pushed
the
feat/encode-registry-and-eof
branch
from
b643b2e
to
7b7f1fb
Compare
|
|
mxinden
approved these changes
Jul 7, 2024
Signed-off-by: Max Inden <mail@max-inden.de>
Signed-off-by: Max Inden <mail@max-inden.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: All credits for the PR, from the initial idea, implementation, and testing, belong to @amunra who is the original author of this PR and #154.
From the original PR description:
Adds new
encode_registryandencode_eoffunctions to allow encoding of parts of the response.This is useful when there are multiple registries at play, or when composing metrics for a process that embeds Rust as part of its logic whilst serving metrics to Prometheus outside of Rust.
Fixes: #153
Refs: #154, #204
Thank you @amunra! 😸