-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regexp params doesn't work when passed as string in arguments #1737
Comments
I would recommend filing issues/PRs against the guides that have the wrong documentation. There's not much we can do about it here. Unless you found the wrong syntax in official Prometheus docs. 😄 |
I'm not sure that this is only a documentation issue.. I mean : edit: |
We already have invalid regexp detection, the |
@SuperQ understood... maybe the issue is that the parsed regepx is |
Yes, that's very likely the problem. The kubernetes yaml is including the quotes when setting the flag. I've been considering creating a more comprehensive status page for the node_exporter, that would include more runtime, build, and of course all of the flags in the output. |
Hrmm yeah I totally see how this could have been me wasting 4h on this..
and invoke that with But if you use something that passes the arguments directly as a list as you did, without a shell interpreting it, it will have the literal " in there.. |
I tacked on some logging improvements to #1743. |
Update netdev and systemd collectors to deprecate poorly chosen flag names. Old flag names to be removed in 2.0.0. prometheus#1742 Add log messages for parsed flag values to help discover quoting isuses in supervisors. prometheus#1737 Signed-off-by: Ben Kochie <superq@gmail.com>
Update netdev and systemd collectors to deprecate poorly chosen flag names. Old flag names to be removed in 2.0.0. prometheus#1742 Add log messages for parsed flag values to help discover quoting isuses in supervisors. prometheus#1737 Signed-off-by: Ben Kochie <superq@gmail.com>
I've lost 4 hours today because of this :
( kbuernetes pod.. )
doesn't work ( meaning that ignored fs types param doesn't have other effect than just disabling the default value of the param ) ,
no error , nothing logged just filesystems doesn't get ignored ( i've started playing out with escaping regex, changhing other settings, changing rootfs path ecc.. )
at the end... the light
this works..
now there are around a lot of examples and tutorial which use the format listed in the first example .. which doesn't work.. at least in kubernetes yaml definition format
( the same is valid for : "--collector.filesystem.ignored-mount-points" ( and probably for all others regexp params? )
I hope that this post could help others that with my same issue tried, I think that this should be better documented/handled because is very nasty unwanted behaviour..
thank you
The text was updated successfully, but these errors were encountered: