Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oracle::variability #165

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Add Oracle::variability #165

merged 3 commits into from
Jan 31, 2024

Conversation

BaxterEaves
Copy link
Contributor

No description provided.

@BaxterEaves BaxterEaves requested a review from a team as a code owner January 23, 2024 17:54
@BaxterEaves BaxterEaves marked this pull request as draft January 23, 2024 17:54
Polars changed the output format to display more rows, so I've moved the
tests to a file in tests/ and use `extraglobs` to pass some polars
config options to get it almost back to how it was. You can now also
prevent plotly from opening a ton of browser windows bu setting the env
var LACE_DOCTEST_NOPLOT=1, which renders plotly to json and ignores the
output using doctest directives. I'd like to prevent matplotlib from
plotting as well.
Copy link
Contributor

@Swandog Swandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One questions about the rust code that isn't a blocker. One question about the changes to Python doctests that I want to get clarity on before I approve.

lace/src/interface/oracle/traits.rs Show resolved Hide resolved
pylace/README.md Show resolved Hide resolved
@BaxterEaves BaxterEaves marked this pull request as ready for review January 26, 2024 18:45
@BaxterEaves BaxterEaves changed the title DRAFT: Add Oracle::variability Add Oracle::variability Jan 26, 2024
Copy link
Contributor

@Swandog Swandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All questsions resolved. SHIP IT

@BaxterEaves BaxterEaves merged commit 43c1c8c into master Jan 31, 2024
23 checks passed
@BaxterEaves BaxterEaves deleted the feature/variance branch January 31, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants