feat(python): Added support for pickling lace.Engine #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidmt
added
enhancement
schmidmt
force-pushed
the
159-add-support-for-multiprocessing-for-pylaces-engine
branch
2 times, most recently
from
fde6635
to
6ccbed7
Compare
schmidmt
force-pushed
the
159-add-support-for-multiprocessing-for-pylaces-engine
branch
from
6ccbed7
to
b29232b
Compare
Swandog
approved these changes
Feb 13, 2024
pylace/src/lib.rs
Outdated
| polars::df! { | ||
| "ID" => [0], | ||
| } | ||
| .expect("Should be a df"), |
There was a problem hiding this comment.
Why do an Ok(thing.expect("") instead of just returning the Result?
There was a problem hiding this comment.
I'm honestly surprised clippy didn't notice it
| sim_a = engine.simulate(["swims", "flys"], n=10) | ||
| sim_b = engine_b.simulate(["swims", "flys"], n=10) | ||
|
|
||
| assert sim_a.equals(sim_b) |
There was a problem hiding this comment.
Good practice to add a test, I've been lagging in that lately
schmidmt
deleted the
159-add-support-for-multiprocessing-for-pylaces-engine
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.