Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canary-release workflow #184

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Fix canary-release workflow #184

merged 4 commits into from
Jan 29, 2024

Conversation

felipecadavid
Copy link
Contributor

Description of changes

This PR fixes the canary-release workflow which wasn't creating canary releases

Checklist

Before merging to main:

  • Tests
  • Manually tested in React apps
  • Changesets
  • Approved

Copy link

changeset-bot bot commented Jan 29, 2024

⚠️ No Changeset found

Latest commit: befb7cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui-kit ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 1:38pm

Copy link
Contributor

@sashathor sashathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a changeset for the PR.

@felipecadavid
Copy link
Contributor Author

felipecadavid commented Jan 29, 2024

LGTM, but please add a changeset for the PR.

@sashathor Does this one really need a changeset? As it is a change that will only affect our workflow and does not cause a version bump I think it should not have a changeset right?

@sashathor
Copy link
Contributor

LGTM, but please add a changeset for the PR.

@sashathor Does this one really need a changeset? As it is a change that will only affect our workflow and does not cause a version bump I think it should have a changeset right?

Actually, you're right. We don't need a changeset in this case 👍

@felipecadavid felipecadavid merged commit 365604c into main Jan 29, 2024
4 checks passed
@felipecadavid felipecadavid deleted the chore/fix-canary-releases branch January 29, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants