Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CherryPick the lastest work for Objective-C over the the 28 branch #17840

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

thomasvl
Copy link
Contributor

No description provided.

The api is annotated that it isn't valid, but incase someone calling code isn't
annotated correct and someone returns nil for another nonnull api, it could happen,
so make it an explicit failure just to be safe.

PiperOrigin-RevId: 662935009
Since a group GPBUnknownField uses a GPBUnknownFields and that is mutable, it needs to be copied so two instances aren't linked.

PiperOrigin-RevId: 663323972
@thomasvl thomasvl requested a review from zhangskz August 16, 2024 13:53
@thomasvl thomasvl requested a review from a team as a code owner August 16, 2024 13:53
@thomasvl thomasvl requested review from dmaclach and removed request for a team and dmaclach August 16, 2024 13:53
@thomasvl thomasvl added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 16, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 16, 2024
@zhangskz zhangskz merged commit bb6ecb9 into protocolbuffers:28.x Aug 16, 2024
167 of 168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants