Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests for recent Bazel versions. For #342. #347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix unit tests for recent Bazel versions. For #342. #347

wants to merge 2 commits into from

Conversation

martijneken
Copy link
Contributor

No description provided.

@martijneken
Fix unit tests for recent Bazel versions.
d324da7 
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Copy link
Contributor Author

Test failures, looking...

@martijneken
Allow noop parameterized tests when engine=null
e2417ea 
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Copy link
Contributor Author

Looks like a failure to serialize proxy_wasm::WasmResult in testing::internal::UniversalPrint (with GCC). Can't repro locally.

@PiotrSikora
Copy link
Member

@martijneken did you ever figure this out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora PiotrSikora is a code owner

@mathetake mathetake Awaiting requested review from mathetake

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martijneken @PiotrSikora