Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(register): add component registration script #36

Merged
merged 3 commits into from
Dec 21, 2023
Merged

feat(register): add component registration script #36

merged 3 commits into from
Dec 21, 2023

Conversation

smithoo
Copy link
Collaborator

@smithoo smithoo commented Dec 20, 2023

Type of PR (check all applicable)

  • Feature (feat)

Summary

컴포넌트를 자동 등록하는 스크립트를 추가합니다

Description

  • components의 디렉토리 중첩을 제거합니다
  • 각 component의 index.ts 파일을 glob으로 import 해서 app에 등록하는 스크립트를 작성했습니다
  • VlossomOptions에 components를 추가해서 원하는 component만 전역 등록하도록 변경합니다 (tree shaking은 추가 작업 예정)
  • 각 컴포넌트에서 정의한 type들을 @/components/types에서 export type 형태로 내보냅니다

@smithoo smithoo self-assigned this Dec 20, 2023
@gmldus gmldus self-requested a review December 21, 2023 02:50
@gmldus gmldus merged commit f33895b into main Dec 21, 2023
6 checks passed
@gmldus gmldus deleted the feat/register branch December 21, 2023 07:11
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmldus gmldus gmldus approved these changes

@yeriiiii yeriiiii yeriiiii approved these changes

@seaneez seaneez Awaiting requested review from seaneez

Assignees

@smithoo smithoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smithoo @gmldus @yeriiiii