Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables rimraf renovate PR to 5.x by replacing rimraf with native fs rm #1243

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Enables rimraf renovate PR to 5.x by replacing rimraf with native fs rm #1243

merged 1 commit into from
Aug 18, 2023

Conversation

trevoring-okta
Copy link
Contributor

@trevoring-okta trevoring-okta commented Aug 18, 2023 •
edited
Loading

@pubkey

This PR contains:

  • Replaces usage of rimraf in code with equivalent native fs call to circumvent browserify's incompatibility with rimraf 5.x and enable renovate PR
  • Shifts rimraf to dev dependency

Describe the problem you have without this PR

  • Current version of rimraf contains a vuln, renovate PR and this PR have been unable to bump to version 5.x because of browserify parsing issues

@pubkey pubkey merged commit b8cc6b3 into pubkey:master Aug 18, 2023
3 checks passed
@pubkey
Copy link
Owner

pubkey commented Aug 18, 2023

Thanks, merged.

@pubkey pubkey mentioned this pull request Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trevoring-okta @pubkey