Fixes Disabling of Markdown buttton on using shortcut keys #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The extra spelling changes were also included as in PR #426 changes were directly made to dist files and these spelling mistakes were in node modules. |
|
@jywarren @VladimirMikulic Please review the changes |
VladimirMikulic
approved these changes
Apr 11, 2020
govindgoel
approved these changes
Apr 25, 2020
|
@jywarren @emilyashley Can you please merge this!! |
|
Oh this makes a ton of sense. Thanks a lot! |
|
I just synced the branch so this should be good to merge once it passes. I'll check back in! |
|
This is so odd. I'll close and reopen to try to retrigger the tests. If this happens again, try that too! |
|
And if it keeps happening, it might need a clean rebase... just an idea! |
|
Aha! Done!!! 🎉 |
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
before changes pressing CTRL + M disabled the Markdown button. Now, It has been fixed.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt jasminefixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!