Remove file button added

[NitinBhasneria]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Fixes: #429

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[NitinBhasneria]

@VladimirMikulic Have a look. Thanks.

[VladimirMikulic]

How many of these "remove file button" PRs do we have? I feel like you spawn each one every day?

[NitinBhasneria]

Nice joke @VladimirMikulic. There is only two PR's I have closed the previous as according to you it was messy. And that why I have open the clean PR of that. Have a look, also you should no talk like this. Just because I always prefer you, you can't say like this.

[VladimirMikulic]

Don't fix the code style manually, that's why I suggest using tools like Prettier.
Prettier won't miss out on this, but we as humans do miss.

[NitinBhasneria]

Ok thank you. I got it. Will do this today itseld @VladimirMikulic

[VladimirMikulic]

@NitinBhasneria I saw your edited comment and you misunderstood me.
I am not angry, I am just suggesting the changes that you need to make to get PR merged.
I don't have the slightest idea why @sashadev-sky deleted my comment, hopefully, you had a chance to read it in your inbox.

The point was, don't open a PR every time someone suggests the changes. (highly anti-pattern)
Just push a commit that includes improvements and that's it, no hard feelings.

[NitinBhasneria]

Sorry for that @VladimirMikulic. Will not do so now onwards and thanks for the guidance.

[VladimirMikulic]

You don't have to apologise. Don't feel bad when you are requested to improve the code.
After all, that's why we use Github and VCS, right?

[NitinBhasneria]

Yea @VladimirMikulic Thanks

[NitinBhasneria]

@jywarren PLease have a look.

[NitinBhasneria]

@emilyashley @jywarren @ebarry have a look at this.

[jywarren]

Hi all, sorry I missed this, and i'll check with @sashadev-sky -- perhaps it was a mistake -- thank you for working through this and I know sometimes online it's hard to be sure your tone is coming through in a friendly way, so I appreciate @NitinBhasneria for speaking up when you felt something and @VladimirMikulic for all your help on this PR. Small conflicts often happen when we are doing a lot of commenting/interacting very quickly and your patience is always appreciated. It's ALWAYS worth the effort to be sure our fellow community members are feeling welcome and supported. Our code of conduct covers really bad behaviors, but it's the small kindnesses that often get us through our days feeling good.

If you would like to discuss further please reach out to me, and I'm always available to listen and offer input -- thanks again for all your hard work. ❤️

[jywarren]

🎉

[keshav234156]

@NitinBhasneria Test are failing due to this PR. Please refine it asap.

[NitinBhasneria]

@keshav234156 It is failing due to #437 as the HTML file in tests is not containing the mainImage id.
Thanks