Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Security] Bump jquery from 3.4.1 to 3.5.0" #520

Closed

Conversation

keshav234156
Copy link
Member

Reverts #468

@jywarren
Copy link
Member

@keshav234156 sez:

@jywarren Due to this PR there were TypeError in test logs. Though test passed. Made a reverted PR #520

Just checking - is this a breaking change in jquery? Because dependabot will try to re-open this... is there another workaround? Thank you!

@keshav234156
Copy link
Member Author

@jywarren This version is completely breaking the jquery. I just checked it locally now that they have fixed this in version 3.5.1. Also available here https://blog.jquery.com/2020/05/04/jquery-3-5-1-released-fixing-a-regression/ . Should we fix it manually or dependabot will open it soon?

@jywarren
Copy link
Member

Ah, i see! Sorry, i totally missed the announcement about the 3.5.0 vs 3.5.1! Can u ping this in the chatroom so folks are aware? What a big reversion...

I don't know if @dependabot knows how to skip withdrawn versions... i think perhaps we could close this and @dependabot would try to open 3.5.1 but i'm not sure. If it doesn't, let's do it manually? Thank you!

@jywarren
Copy link
Member

Oh aha! Here! I'll just merge this then: #513

@jywarren jywarren closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants