Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading Test #545

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Heading Test #545

wants to merge 6 commits into from

Conversation

cypherean
Copy link
Contributor

@cypherean cypherean commented Jun 27, 2020

To be merged after #557 . Tests adding a heading and switching b/w different heading sizes.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@cypherean cypherean force-pushed the heading_test branch 3 times, most recently from 92c1768 to 34620ad Compare June 27, 2020 07:47
@govindgoel
Copy link
Member

govindgoel commented Jul 13, 2020

@Shreyaa-s Both the above PR's are merged so you can change the description and tell the status whether it is in WIP or it's done.

@cypherean
Copy link
Contributor Author

Can only be merged after #557 , I'll update the description.

@gitpod-io
Copy link

gitpod-io bot commented Jul 13, 2020

@jywarren
Copy link
Member

That's been merged, so I've reset this, hopefully it works, but it may need a rebase. Thanks!

Also, a tip is that you can create a PR that builds on another PR branch. Sometimes this can help with such ordering!

@jywarren
Copy link
Member

Or, you can include the other PR's commits in this one, and once the other is merged, and this updated, the extra commits would just disappear. Fun tricks! 🎉

@Sagarpreet
Copy link
Contributor

@shreyaa-sharmaa any updates?

@cypherean
Copy link
Contributor Author

@sagarpreet-chadha The test is correct. But the change for which I wrote this was introduced in Woofmark. Since we've reverted the latest update of woofmark, the tests won't pass right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants