Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact Design for main Image Module #594

Merged
merged 5 commits into from
Aug 14, 2020
Merged

Conversation

cypherean
Copy link
Contributor

@cypherean cypherean commented Aug 12, 2020

Fixes #592

Tablet:

Screenshot from 2020-08-13 02-48-24
Screenshot from 2020-08-13 02-47-19

Phone:

mobile

Laptop:

Screenshot from 2020-08-13 02-47-59
Screenshot from 2020-08-13 02-48-10

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Aug 12, 2020

@cypherean
Copy link
Contributor Author

cypherean commented Aug 12, 2020

Please review @jywarren @sagarpreet-chadha

@jywarren
Copy link
Member

This looks really great, @shreyaa-sharmaa !!! I wonder if we can get the buttons to be side-by-side on mobile, what do you think?

I also wonder, is it possible to have the "remove file" button only appear once there is an image? This maybe could also be done in CSS, i guess, or with $('.button').hide() maybe?

Thanks, this is great!!!

@cypherean
Copy link
Contributor Author

If we place the buttons side by side then where should we place the progress bar and filename? Above the buttons in both cases?
I'll make the changes to remove file button.

@cypherean
Copy link
Contributor Author

Hides remove file button when not in use. Also hides the filename when file is removed.
GIF of the changes:
simplescreenrecorder-2020-08-14_03 39 30

@jywarren
Copy link
Member

Awesome, and yes, that sounds great regarding the progress bar! Thanks so much!!!

@cypherean
Copy link
Contributor Author

Does this look okay @jywarren ?
Screenshot from 2020-08-14 04-10-34

@cypherean
Copy link
Contributor Author

cypherean commented Aug 13, 2020

Mobile:
mobile

Also noting the slight change in position of filename now:
Screenshot from 2020-08-14 04-18-25

@jywarren
Copy link
Member

It looks tremendous. @shreyaa-sharmaa this is really excellent work. Merging now and releasing the next version!

@jywarren jywarren merged commit 76bb3b8 into publiclab:main Aug 14, 2020
@jywarren
Copy link
Member

Hi @shreyaa-sharmaa - now that this is merged, can you be sure that the changes are also implemented in plots2's matching templates? Thank you!!!

@jywarren
Copy link
Member

Hi @shreyaa-sharmaa i'd love to publish this on plots2 if you have any time today! I know it's probably late there. If not, we can push through a small new publication later in the week. Thanks so much for your help!

@cypherean
Copy link
Contributor Author

On it @jywarren!

@cypherean
Copy link
Contributor Author

Linking it here publiclab/plots2#8327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More compact design for main image module
2 participants