-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact Design for main Image Module #594
Conversation
Please review @jywarren @sagarpreet-chadha |
This looks really great, @shreyaa-sharmaa !!! I wonder if we can get the buttons to be side-by-side on mobile, what do you think? I also wonder, is it possible to have the "remove file" button only appear once there is an image? This maybe could also be done in CSS, i guess, or with Thanks, this is great!!! |
If we place the buttons side by side then where should we place the progress bar and filename? Above the buttons in both cases? |
Awesome, and yes, that sounds great regarding the progress bar! Thanks so much!!! |
Does this look okay @jywarren ? |
It looks tremendous. @shreyaa-sharmaa this is really excellent work. Merging now and releasing the next version! |
Hi @shreyaa-sharmaa - now that this is merged, can you be sure that the changes are also implemented in |
Hi @shreyaa-sharmaa i'd love to publish this on |
On it @jywarren! |
Linking it here publiclab/plots2#8327 |
Fixes #592
Tablet:
Phone:
Laptop:
grunt jasmine
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!