Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tags input (matching legacy editor of note editor) to new wiki form and wiki editing page. #8229

Closed
Shulammite-Aso opened this issue Aug 3, 2020 · 4 comments · Fixed by #8260
Labels
feature explains that the issue is to add a new feature outreachy

Comments

@Shulammite-Aso
Copy link
Collaborator

Please describe the desired behavior.
Describe the solution you'd like.

This is a feature request by the PL staffs, to have the new wiki form and wiki editing page include field for tag input.

will be working on this soon.

Additional context (optional)
Feel free to include any applicable: code, screenshots, or gifs.

@Shulammite-Aso Shulammite-Aso added feature explains that the issue is to add a new feature outreachy labels Aug 3, 2020
@jywarren
Copy link
Member

jywarren commented Aug 4, 2020

Just chiming in with some code links!!!

the tags form from the notes legacy editor, which should work:

<div class="input-group tags-input">
<div class="input-group-prepend">
<span class="input-group-text"><i class="fa fa-tags"></i></span>
</div>
<input autocomplete="off" class="form-control" id="taginput" tabindex="3" name="tags" type="text" <% if params[:tags] || (@node && @node.power_tag('question')) || (@node && @node.tagnames) %>value="<%= params[:tags] || @node.tagnames.join(',') %><%= ','+@node.power_tag('question') if @node && @node.power_tag('question') != '' %>"<% else %>placeholder="balloon-mapping,gulf-coast"<% end %> data-provide="typeahead" />
</div>

Maybe we can excerpt it into a partial template, and just include it in the wiki editor too?

And then we'll have to confirm that the code to actually add the tags is included in the wiki controller for both create and update --

params[:tags]&.tr(' ', ',')&.split(',')&.each do |tagname|
@node.add_tag(tagname.strip, current_user)
end

Hope that helps!!!

@Shulammite-Aso
Copy link
Collaborator Author

Hope that helps!!!

This will help. @jywarren Another thing however is that i'm not able to see .../wiki/new with passenger start, so i don't know how else to tell if its working. unless maybe i push what i have, then somebody else confirms if it works. If it will actually work this way.

@jywarren
Copy link
Member

jywarren commented Aug 6, 2020

Oh, is it because of your user account status? I think you should be able to log in locally with the admin account, maybe the pwd is password? Or it's written in the /db/seeds.rb file. IT could be secret... not sure.

If not, is there another error in loading that page?

Thanks!

@Shulammite-Aso
Copy link
Collaborator Author

Oh, is it because of your user account status? I think you should be able to log in locally with the admin account, maybe the pwd is password? Or it's written in the /db/seeds.rb file. IT could be secret... not sure.

If not, is there another error in loading that page?

Thanks!

No other error, except taking me to the dashboard page instead. I'm going to try logging in as admin however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature explains that the issue is to add a new feature outreachy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants