Tracking Editor features 🧨

[Sagarpreet]

Resolve outstanding issues remaining from the Summer 2020 Editor Team of 4 work, also documented here: https://pad.publiclab.org/p/editor-tasks

• poorly wrapping Markdown button on narrower screens on /post

• STATUS: Dev completed

• PR: poorly wrapping Markdown button on narrower screens on /post #635

• odd folding (maybe bootstrap 3/4 issue?) of main image column, related to Fix odd looking uploaded main images #612

• STATUS: Dev completed

• The image issue is resolved here: Fix odd looking uploaded main images #612, remaining issues solved here: Fixes odd looking css in image module plots2#8474, Fixes odd looking css: in image module everything should be in one row #629

• more explanation (help buttons/links) and bootstrap 4 styling of Custom Insert module, possibly covered by upgrade Bootstrap to 4 #566, Check that location sharing is enabled by user before posting it #444

• STATUS: Dev completed

• PR: upgrade Bootstrap to 4 #636

• Comment-related issues listed on GSoC / Outreachy Editor Project Planning Issues and General Disscussion #490 (comment)

• STATUS: Dev completed

• Issue: Ensure formatting toolbars on comments appear in all variations plots2#8475

• PR: Ensure formatting toolbars on comments appear in all variations plots2#8477

Editor repo tasks:

• ensure the formatting toolbar (in both rich and markdown modes) doesn't stick to the bottom of the frame as we scroll far enough down or up that the text area is no longer shown at all
• STATUS: Done
• PR: fix toolbar stickness issue  #522

plots2 tasks:

• Re-order legacy and comment toolbars so order of tools matches that of Rich Text Editor, for consistency

• STATUS: Done

• Issue: Re-order legacy and comment toolbars so order of tools matches that of Rich Text Editor plots2#8259

• PR: Adds image button to wiki Editor plots2#8252

• Add a button for uploading images to the Wiki Editor toolbar that would look similar to the Rich Editor's button

• STATUS: Done

• PR: Adds image button to wiki Editor plots2#8252), the image button already exists in comment editor.

• Repair "click to select an image" functionality on comment (and comment reply) image uploads.
  Issue:

• STATUS: Done

• PR: https://github.com/publiclab/plots2/pull/8240/files

• Ensure formatting toolbars on comments appear in all variations:

• comment
• reply to comment
• comment just posted (form inserted via AJAX)
• reply to comment just posted
• editing existing comments
• editing comments just posted
• editing comment replies
• editing comment replies just posted

• STATUS: Done
  Issue: Ensure formatting toolbars on comments appear in all variations plots2#8475

• PR: Ensure formatting toolbars on comments appear in all variations plots2#8636

• add tags input (matching legacy editor of note editor) to new wiki form and wiki editing page:
  <input autocomplete="off" class="form-control" id="taginput" tabindex="3" name="tags" type="text" placeholder="balloon-mapping,gulf-coast" data-provide="typeahead">

• and a controller code addition matching: https://github.com/publiclab/plots2/blob/cd9bd3a2988569632f09c4dd0fad89aa30abbe20/app/controllers/notes_controller.rb#L184-L188 or https://github.com/publiclab/plots2/blob/cd9bd3a2988569632f09c4dd0fad89aa30abbe20/app/controllers/notes_controller.rb#L100-L102

• STATUS: Done

• Issue: add tags input (matching legacy editor of note editor) to new wiki form and wiki editing page. plots2#8229

• PR's: https://github.com/publiclab/plots2/pull/8295/files, https://github.com/publiclab/plots2/pull/8260/files

• adjust OpenGraph tags for questions/notes/wikis so that if no main image is available, openGraph lead image tags show a "scraped" lead image (see how we do this in card display, for example https://publiclab.org/tag/bucket-monitor shows a scraped lead image for https://publiclab.org/notes/kgradow1/07-03-2020/bucket-monitor-prototype)

• STATUS: Done

• PR: (to unstable branch) Adjust opengraph tag to show scrapped image plots2#8291

• Create a POST route at /editor/preview which simply renders a simulated "note" or "wiki page" using the Markdown in the "body" and "title" POST variables. Nothing is saved in the db, and we repoint all editor Preview buttons at this. (not sure about comment previews though, probably not those). We also make a Preview button for the rich editor pointed at this. All open in a new tab, and should use the [->] "open in new tab" icon from FontAwesome

• STATUS: Dev Completed

• Issue: Add a new /preview route to open editor preview in new tab plots2#8560
  PR: Notes Preview plots2#8620, [WIP ]Add a new /preview route to open editor preview in new tab  plots2#8604

• Add "Preview" button next to the Publish button [ON WHICH EDITORS?] that opens a preview of your content in a new tab

• STATUS: Dev Completed

• Issue: Add a new /preview route to open editor preview in new tab plots2#8560
  PR: Notes Preview plots2#8620, [WIP ]Add a new /preview route to open editor preview in new tab  plots2#8604

• Create and document, in coordination with the Lead Code Coordinator, a “first-timers-only first release” program for use in Outreachy and Google Summer of Code programs. The prototype should be in process as soon as the October 2020 Outreachy Contribution Period and ready to use in the December 1 2020 - March 2 2021 Outreachy Internship period.

• STATUS: Draft completed

• DRAFTED here: https://docs.google.com/document/d/1GVp0fX79fXEqF6C0VN86CHi40SMS4CIfDZm5NT_9Elk/edit?usp=sharing

[welcome]

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

[Sagarpreet]

Done => Merged
Needs Clarity => Need help from @jywarren , @ebarry
Work in Progress => Something is left to do in the PR

[jywarren]

This is looking awesome, Sagarpreet, thank you!

[ebarry]

Thank you @Sagarpreet ! I don't see any more items labelled "needs clarification" -- is that right?

[Sagarpreet]

Correct @ebarry 👍
These were resolved by Jeff and some by you on gitter 😄

[jywarren]

I think we're just waiting on publiclab/plots2#8714 - publishign the Editor v3 to plots2 -- plus the Preview route and follow-ups, right?

[sagarpreet-chadha]

Correct Jeff 👍

[Sagarpreet]

NPM release for all above changes: #657
plots2 integration of all above changes: publiclab/plots2#8744

[jywarren]

Noting bold bug PR at #659 as well! Thank you!!

[jywarren]

Updated the Preview project checkboxes!!!! Yay!!!

[jywarren]

This is all done, i believe!!! Thanks so much @Sagarpreet !!!!