-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(to unstable branch) Adjust opengraph tag to show scrapped image #8291
(to unstable branch) Adjust opengraph tag to show scrapped image #8291
Conversation
* fixes for publiclab#7965 * count fixes
* Update tag_test.rb * Update tag_test.rb * Update tag_test.rb * Update tag.rb
* queue feature spam2 * indentation issue * bulk moderation for comments and tag count in queue * indentation * moderator queue * batch controller * first-timmer issue * tag filter * queue indentation * all tags filter queue
* Don't let newcomers edit wiki pages (controller-level) * Update wiki_controller.rb * Update wiki_controller_test.rb * Update wiki_controller_test.rb * Update wiki_controller_test.rb * Update wiki_controller_test.rb * Update wiki_controller.rb * Update wiki_controller.rb * Update wiki_controller_test.rb * Update wiki_controller_test.rb
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.88.0 to 0.89.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.88.0...v0.89.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.2.3 to 0.2.5. - [Release notes](https://github.com/codecov/codecov-ruby/releases) - [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-ruby@v0.2.3...v0.2.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [rdiscount](https://github.com/davidfstr/rdiscount) from 2.2.0.1 to 2.2.0.2. - [Release notes](https://github.com/davidfstr/rdiscount/releases) - [Changelog](https://github.com/davidfstr/rdiscount/blob/master/CHANGELOG.md) - [Commits](davidfstr/rdiscount@2.2.0.1...2.2.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* adding tags in modals of Nodes publiclab#8230 * refactored publiclab#8230 * fixed tag path in the modal publiclab#8230 also fixed extra spacing when no tags on the modal
Changed "btn btn-xs" to "btn btn-sm"
Codecov Report
@@ Coverage Diff @@
## unstable #8291 +/- ##
============================================
- Coverage 81.68% 81.32% -0.37%
============================================
Files 100 101 +1
Lines 5842 5873 +31
============================================
+ Hits 4772 4776 +4
- Misses 1070 1097 +27
|
Hi @sagarpreet-chadha @jywarren @cesswairimu can you merge this? Using it to test #8284 |
Yep! Done! Thanks!!!! |
This didn't work.🙊 I guess i'ld have to request from @cesswairimu or anybody who knows about how to access an image(preferably the first image) from the post's body from this file. Also perhaps default to the public lab logo when the post has no image at all: main_image and post body image. Will this be okay? |
Hey @Shulammite-Aso , Line 91 in cc59cda
So once you have reference of that node ruby object, using images Thanks! 😄 Also in the documentation of twitter it is mentioned that the images size should be of certain size and ratio: https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary-card-with-large-image We can test the images displayed using these tools provided by FB and twitter: |
Also you can use gitpod url to test instead of pushing to unstable: |
Fixes #8273
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!