improve UI of digest email #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Generated by 🚫 Danger |
|
Hi @jywarren, we can now have a view of the mailers on local machine by visiting localhost:3000/rails/mailers. Can you have a look at it? |
|
Very cool!
This looks great. Ready to merge? |
|
Maybe we should name it |
|
the links could be at the bottom... |
Hi @jywarren, exactly where should it be? In the email subject or should we replace Bob's digest (in above mail)? |
|
Sure, we can put the links at bottom. Will do |
ViditChitkara
force-pushed
the
digest-template
branch
from
8b7cfea
to
1b28292
Compare
|
@jywarren I have made the changes. I guess this is ready now! |
|
Awesome! |
stefannibrasil
pushed a commit
to milaaraujo/plots2
that referenced
this pull request
Aug 3, 2018
* improve UI of digest email * minor changes * added links to settings and subscriptions
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* improve UI of digest email * minor changes * added links to settings and subscriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3061