Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.52.1 to 0.60.0 #3827

Merged
merged 2 commits into from
Nov 8, 2018

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubocop from 0.52.1 to 0.60.0.

Release notes

Sourced from rubocop's releases.

RuboCop 0.60

New features

  • #5980: Add --safe and --safe-auto-correct options. ([Darhazer][])
  • #4156: Add command line option --auto-gen-only-exclude. ([Ana06][], [jonas054][])
  • #6386: Add VersionAdded meta data to config/default.yml when running rake new_cop. ([koic][])
  • #6395: Permit to specify TargetRubyVersion 2.6. ([koic][])
  • #6392: Add Whitelist config to Rails/SkipsModelValidations rule. ([DiscoStarslayer][])

Bug fixes

  • #6330: Fix an error for Rails/ReversibleMigration when using variable assignment. ([koic][], [scottmatthewman][])
  • #6331: Fix a false positive for Style/RedundantFreeze and a false negative for Style/MutableConstant when assigning a regexp object to a constant. ([koic][])
  • #6334: Fix a false negative for Style/RedundantFreeze when assigning a range object to a constant. ([koic][])
  • #5538: Fix false negatives in modifier cops when line length cop is disabled. ([drenmi][])
  • #6340: Fix an error for Rails/ReversibleMigration when block argument is empty. ([koic][])
  • #6274: Fix "[Corrected]" message being displayed even when nothing has been corrected. ([jekuta][])
  • #6380: Allow use of a hyphen-separated frozen string literal in Emacs style magic comment. ([y-yagi][])
  • Fix and improve LineLength cop for tab-indented code. ([AlexWayfer][])

Changes

  • #3727: Enforce single spaces for key option in Layout/AlignHash cop. ([albaer][])
  • #6321: Fix run of RuboCop when cache directory is not writable. ([Kevinrob][])

[Darhazer]: https://github.com/Darhazer
[Ana06]: https://github.com/Ana06
[jonas054]: https://github.com/jonas054
[koic]: https://github.com/koic
[DiscoStarslayer]: https://github.com/DiscoStarslayer
[scottmatthewman]: https://github.com/scottmatthewman
[drenmi]: https://github.com/drenmi
[jekuta]: https://github.com/jekuta
[y-yagi]: https://github.com/y-yagi
[AlexWayfer]: https://github.com/AlexWayfer
[albaer]: https://github.com/albaer
[Kevinrob]: https://github.com/Kevinrob

RuboCop 0.59.2

Bug fixes

  • #6266: Fix a false positive for Rails/HasManyOrHasOneDependent when using associations of Active Resource. ([tejasbubane][], [koic][])
  • #6296: Fix an auto-correct error for Style/For when setting EnforcedStyle: each and for dose not have do or semicolon. ([autopp][])
  • #6300: Fix a false positive for Layout/EmptyLineAfterGuardClause when guard clause including heredoc. ([koic][])
  • #6287: Fix AllowURI option for Metrics/LineLength cop with disabled Layut/Tab cop. ([AlexWayfer][])
  • #5338: Move checking of class- and module defining blocks from Metrics/BlockLength into the respective length cops. ([drenmi][])
  • #2841: Fix Style/ZeroLengthPredicate false positives when inspecting Tempfile, StringIO, and File::Stat objects. ([drenmi][])
  • #6305: Fix infinite loop for Layout/EmptyLinesAroundAccessModifier and Layout/EmptyLinesAroundAccessModifier when specifying a superclass that breaks the line. ([koic][])
  • #6007: Fix false positive in Style/IfUnlessModifier when using named capture. ([drenmi][])
  • #6311: Prevent Style/Semicolon from breaking on single line if-then-else in assignment. ([drenmi][])
... (truncated)
Changelog

Sourced from rubocop's changelog.

0.60.0 (2018-10-26)

New features

  • #5980: Add --safe and --safe-auto-correct options. ([Darhazer][])
  • #4156: Add command line option --auto-gen-only-exclude. ([Ana06][], [jonas054][])
  • #6386: Add VersionAdded meta data to config/default.yml when running rake new_cop. ([koic][])
  • #6395: Permit to specify TargetRubyVersion 2.6. ([koic][])
  • #6392: Add Whitelist config to Rails/SkipsModelValidations rule. ([DiscoStarslayer][])

Bug fixes

  • #6330: Fix an error for Rails/ReversibleMigration when using variable assignment. ([koic][], [scottmatthewman][])
  • #6331: Fix a false positive for Style/RedundantFreeze and a false negative for Style/MutableConstant when assigning a regexp object to a constant. ([koic][])
  • #6334: Fix a false negative for Style/RedundantFreeze when assigning a range object to a constant. ([koic][])
  • #5538: Fix false negatives in modifier cops when line length cop is disabled. ([drenmi][])
  • #6340: Fix an error for Rails/ReversibleMigration when block argument is empty. ([koic][])
  • #6274: Fix "[Corrected]" message being displayed even when nothing has been corrected. ([jekuta][])
  • #6380: Allow use of a hyphen-separated frozen string literal in Emacs style magic comment. ([y-yagi][])
  • Fix and improve LineLength cop for tab-indented code. ([AlexWayfer][])

Changes

  • #3727: Enforce single spaces for key option in Layout/AlignHash cop. ([albaer][])
  • #6321: Fix run of RuboCop when cache directory is not writable. ([Kevinrob][])

0.59.2 (2018-09-24)

New features

  • Update Style/MethodCallWithoutArgsParentheses to highlight the closing parentheses in additition to the opening parentheses. ([rrosenblum][])

Bug fixes

  • #6266: Fix a false positive for Rails/HasManyOrHasOneDependent when using associations of Active Resource. ([tejasbubane][], [koic][])
  • #6296: Fix an auto-correct error for Style/For when setting EnforcedStyle: each and for dose not have do or semicolon. ([autopp][])
  • #6300: Fix a false positive for Layout/EmptyLineAfterGuardClause when guard clause including heredoc. ([koic][])
  • #6287: Fix AllowURI option for Metrics/LineLength cop with disabled Layut/Tab cop. ([AlexWayfer][])
  • #5338: Move checking of class- and module defining blocks from Metrics/BlockLength into the respective length cops. ([drenmi][])
  • #2841: Fix Style/ZeroLengthPredicate false positives when inspecting Tempfile, StringIO, and File::Stat objects. ([drenmi][])
  • #6305: Fix infinite loop for Layout/EmptyLinesAroundAccessModifier and Layout/EmptyLinesAroundAccessModifier when specifying a superclass that breaks the line. ([koic][])
  • #6007: Fix false positive in Style/IfUnlessModifier when using named capture. ([drenmi][])
  • #6311: Prevent Style/Semicolon from breaking on single line if-then-else in assignment. ([drenmi][])
  • #6315: Fix an error for Rails/HasManyOrHasOneDependent when an Active Record model does not have any relations. ([koic][])
  • #6316: Fix an auto-correct error for Style/For when setting EnforcedStyle: each with range provided to the for loop without a do keyword or semicolon and without enclosing parenthesis. ([lukasz-wojcik][])
  • #6326: Fix an alignment source for Layout/RescueEnsureAlignment when using inline access modifier. ([andrew-aladev][])

Changes

  • #6286: Allow exclusion of certain methods for Metrics/MethodLength. ([akanoi][])
... (truncated)
Commits
  • 014639f Cut 0.60
  • ee8062f Tweak a changelog entry
  • 9f518b6 Merge pull request #6401 from koic/insert_newline_at_eof_of_changelog
  • 4fcae9e Insert a newline at EOF of CHANGELOG.md
  • c77387c [Fix Tag logins #6326] Fix alignment in Layout/RescueEnsureAlignment when using inline a...
  • 1f00c77 Fix and improve LineLength cop for tab-indented code
  • f79d183 Add Whitelist config to Rails/SkipsModelValidations (#6392)
  • 87b0065 Changes to MkDocs / ReadTheDocs
  • 6ce48b9 Permit to specify TargetRubyVersion 2.6
  • 741cd6c Suppress deprecation warnings of Psych.safe_load args in Ruby 2.6
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Oct 29, 2018
@plotsbot
Copy link
Collaborator

plotsbot commented Oct 29, 2018

1 Message
📖 @dependabot[bot] Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member

jywarren commented Nov 2, 2018

@siaw23 or @ryzokuken would you mind testing this proposed update and seeing if it runs smoothly? Then we can merge in this fix. You might like dependabot -- pretty cool service!

@ryzokuken
Copy link
Member

@jywarren looks great. Will look into this.

@ryzokuken
Copy link
Member

@jywarren it looks just fine to me. Did we try the lint output?

@Radhikadua123
Copy link
Contributor

Where do we run robocop ? I was thinking that we should setup “overcommit” for our project which would run robocop hook when code is committed.

@siaw23-retired
Copy link
Collaborator

Ok so with this upgrade you have to specifically add - '*/**/*.rb' to the Include in rubocop.yml. Otherwise Rubocop won't check for any file. Other than that all's fine with this one @jywarren

@ryzokuken
Copy link
Member

Seems like I'm truly out of loop with Rubocop. Thanks, @siaw23.

@jywarren LGTM with @siaw23's proposed changes.

@ghost ghost assigned jywarren Nov 6, 2018
@ghost ghost added the in progress label Nov 6, 2018
@jywarren
Copy link
Member

jywarren commented Nov 6, 2018

OK, i've added a commit directly to this PR, we'll see!

@jywarren jywarren merged commit 12a528d into master Nov 8, 2018
@ghost ghost removed the in progress label Nov 8, 2018
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-0.60.0 branch November 8, 2018 19:28
@jywarren
Copy link
Member

jywarren commented Nov 8, 2018

Awesome, thanks everyone for the help!!!

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* Bump rubocop from 0.52.1 to 0.60.0

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.52.1 to 0.60.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.52.1...v0.60.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Update .rubocop.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants