Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar tags cards #6315

Merged
merged 15 commits into from
Sep 23, 2019
Merged

Sidebar tags cards #6315

merged 15 commits into from
Sep 23, 2019

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Sep 22, 2019

Fixes #6005 - replaces #6124 🎉

OK, I worked on this a good bit to get it to render well with many different combinations of tags, different screen sizes, etc. I hope this gets most of the edge cases, but it's not perfect... we may need to do some follow-up tweaks. In any case, here's what I'm seeing locally:

Mobile width initially:

image

And expanded:

image

Full width initially:

image

And expanded:

image

@jywarren jywarren mentioned this pull request Sep 22, 2019
5 tasks
@jywarren jywarren merged commit 1cfd91a into publiclab:master Sep 23, 2019
@jywarren jywarren mentioned this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New sidebar design implementation for the notes show page
2 participants