Skip to content

Commit

Permalink
Allow packages without plugins to build again
Browse files Browse the repository at this point in the history
Packages (like pulp_file and pulp-certguard) that do not provide any
plugin anymore, bindings artifacts are not generated and so should not
be attempted to be uploaded or published after all.
We may however still be able to ship the "empty" package.
  • Loading branch information
mdellweg committed Jul 22, 2024
1 parent cd6f9f0 commit baebef5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions templates/github/.github/workflows/build.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ jobs:
if-no-files-found: "error"
retention-days: 5
overwrite: true
{%- if plugins %}
{{ run_script(name="Build Python bindings packages", file="build_python_client.sh") | indent(6) }}
- name: "Upload python client packages"
uses: "actions/upload-artifact@v4"
Expand Down Expand Up @@ -98,4 +99,5 @@ jobs:
retention-days: 5
overwrite: true
{%- endif %}
{%- endif %}
...
4 changes: 4 additions & 0 deletions templates/github/.github/workflows/publish.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
.github/workflows/scripts/publish_plugin_pypi.sh {{ "${{ github.ref_name }}" }}
{%- endif %}

{%- if plugins %}
{%- if deploy_client_to_pypi %}
publish-python-bindings:
runs-on: "ubuntu-latest"
Expand Down Expand Up @@ -120,6 +121,7 @@ jobs:
run: |
bash .github/workflows/scripts/publish_client_gem.sh {{ "${{ github.ref_name }}" }}
{%- endif %}
{%- endif %}

create-gh-release:
runs-on: "ubuntu-latest"
Expand All @@ -128,12 +130,14 @@ jobs:
{%- if deploy_to_pypi %}
- "publish-package"
{%- endif %}
{%- if plugins %}
{%- if deploy_client_to_pypi %}
- "publish-python-bindings"
{%- endif %}
{%- if deploy_client_to_rubygems %}
- "publish-ruby-bindings"
{%- endif %}
{%- endif %}

steps:
- name: "Create release on GitHub"
Expand Down
2 changes: 2 additions & 0 deletions templates/github/.github/workflows/test.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ jobs:
with:
name: "api_spec"
path: "{{ plugin_name }}/"
{%- if plugins %}

- name: "Download client packages"
uses: "actions/download-artifact@v4"
Expand All @@ -75,6 +76,7 @@ jobs:
tar xvf "../../{{ plugin_name }}/{{ plugin.app_label }}-python-client.tar"
popd
{%- endfor %}
{%- endif %}

{{ install_python_deps(["towncrier", "twine", "wheel", "httpie", "docker", "netaddr", "boto3", "ansible", "mkdocs", "jq", "jsonpatch"]) | indent(6) }}

Expand Down

0 comments on commit baebef5

Please sign in to comment.