Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose canny threshold parameter in the 2D detector menu #2305

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Expose canny threshold parameter in the 2D detector menu #2305

merged 3 commits into from
Feb 9, 2023

Conversation

papr
Copy link
Contributor

@papr papr commented Feb 2, 2023

No description provided.

N-M-T
N-M-T reviewed Feb 9, 2023
View reviewed changes
Copy link
Contributor

@N-M-T N-M-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the initial text was fine. Nevertheless, I added an alternative. No preference which gets used!

papr and others added 2 commits February 9, 2023 11:50
@papr @N-M-T
Apply improved wording
2aadeeb 
Co-authored-by: Neil M. Thomas <neil87@mail.com>
@papr
Terminate string lietral
bcce5bf
@papr papr merged commit d080a59 into develop Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-M-T N-M-T N-M-T left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@papr @N-M-T