Lower 3d search confidence results by 40% #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confidence for 3d search results was overestimated. This becomes apparent during blinks when 2d detection is typically low and 3d search is applied. The resulting pupil detections are quite noisy compared to their non-3d-search results counterparts with comparable confidence values. This PR attempts to solve this by reducing the 3d search result confidence by 40%.
papr
added a commit
to pupil-labs/pupil
that referenced
this pull request
Oct 14, 2021
Requires pye3d v0.2.0 - See pupil-labs/pye3d-detector#36
papr
pushed a commit
that referenced
this pull request
Feb 24, 2022
This change adds `nitpicky=True` (which is an equivalent of `-n`) to make Sphinx emit warnings for any references to non-existing targets. Then, it adds `-W` to make it fail whenever a single warning is seen. Finally, `--keep-going` allows Sphinx to print out all the warnings before exiting instead of showing just one and bailing. Resolves #29 Refs: * https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-n * https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-W * https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-keep-going
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confidence for 3d search results was overestimated. This becomes apparent during blinks when 2d detection
is typically low and 3d search is applied. The resulting pupil detections are quite noisy compared to
their non-3d-search results counterparts with comparable confidence values.
This PR attempts to solve this by reducing the 3d search result confidence by 40%.