(CONT-811) Add Ruby 3.2 support and Remove support for Ruby 2.5 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Mar 29, 2023
| @@ -3,7 +3,7 @@ | |||
| rescue | |||
| # monkeypatch String#% into Ruby 1.8.7 | |||
There was a problem hiding this comment.
Given the lower bound is now set at 2.5, I wonder how much of this could be dropped.
There was a problem hiding this comment.
yes I've wondered about this file. I'll discuss this with the team
There was a problem hiding this comment.
hey @ekohl. I had a look at this file and am not entirely sure what its purpose is and so don't feel entirely confident to make any changes to it. In the interest of moving on with adding ruby 3 support across our tools I'm going to get this PR merged but add a ticket to our backlog to investigate this more. Thanks for highlighting this for us.
…ng rubocop_todo for now until all cop conflicts are sorted.
… we already use GEM_HOST_API_KEY in our gem_release workflow
…accounted for with the introduction of Dir.home
GSPatton
force-pushed
the
CONT-811-add_ruby_3
branch
from
7ddba1b
to
95d7dff
Compare
jordanbreen28
approved these changes
Apr 6, 2023
GSPatton
added
backwards-incompatible
and removed
enhancement
chelnak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the release of Puppet 8, this PR adds Ruby 3.2 support and removes Ruby 2.5 for puppet-lint.