(CAT-1167) Fix failing legacy fact autocorrector #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jul 27, 2023
|
git says the file is now marked executeable. Was that on purpose? |
|
Removing some unnecessary tests and implementing another one to keep check on the new behaviour. Unit tests for legacy and top scope plugins should be plenty enough here tbh. Also, I dont think I intended to make it executable. Must have assigned it 755 at some point by mistake. |
Prior to this commit, attempting to autocorrect a legacy fact would output the wrong result. This happened due to a conflict between the actions of the legacy fact plugin and the interference of the top scope fact plugin. This commit aims to prevent the top scope fact plugin from attempting to correct any legacy fact by whitelisting all legacy keywords. Legacy fact plugin already performs the work of the top scope fact plugin so no functionality should be lost.
LukasAud
force-pushed
the
bugfix-legacy_fact_corrector
branch
from
cb26a5b
to
bea0e5a
Compare
bastelfreak
approved these changes
Jul 27, 2023
LukasAud
changed the title
GSPatton
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, attempting to autocorrect a legacy fact would output the wrong result. This happened due to a conflict between the actions of the legacy fact plugin and the interference of the top scope fact plugin.
This commit aims to prevent the top scope fact plugin from attempting to correct any legacy fact by whitelisting all legacy keywords. Legacy fact plugin already performs the work of the top scope fact plugin so no functionality should be lost.
This should fix #106 and close #114
Checklist