Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-16) Do not warn on "\s" string literal #20

Merged
merged 1 commit into from
Sep 13, 2021
Merged

(GH-16) Do not warn on "\s" string literal #20

merged 1 commit into from
Sep 13, 2021

Conversation

sanfrancrisko
Copy link

Prior to this commit, if the \s escape sequence was used, this
would cause a F+ from the double_quoted_strings check.

This commit updates the double_quoted_string check to permit the
\s string literal.

Resolves: #16

Prior to this commit, if the `\s` escape sequence was used, this
would cause a F+ from the `double_quoted_strings` check.

This commit updates the `double_quoted_string` check to permit the
`\s` string literal.
@sanfrancrisko sanfrancrisko added the bug Something isn't working label Sep 13, 2021
@sanfrancrisko sanfrancrisko requested a review from a team September 13, 2021 15:05
@sanfrancrisko sanfrancrisko self-assigned this Sep 13, 2021
@da-ar da-ar merged commit bbdfc5f into puppetlabs:master Sep 13, 2021
@sanfrancrisko sanfrancrisko deleted the GH-16/master/double_quoted_strings_f+ branch September 13, 2021 15:15
@sanfrancrisko sanfrancrisko removed the bug Something isn't working label Sep 13, 2021
@chelnak chelnak added maintenance bug Something isn't working and removed maintenance labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

double_quoted_strings does not permit space escape sequence
3 participants