Don't print GitHub annotations in JSON mode #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output does not mix well. This does mean the PDK can't use these annotations, but at least it doesn't break it either.
binford2k
approved these changes
Feb 4, 2022
bastelfreak
approved these changes
Feb 4, 2022
|
fwiw, because of the way the PDK runs tools in background shells and parses all the output as JSON, it wasn't ever going to be able to use this directly anyway. The PDK will have to learn annotations all on its own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output does not mix well. This does mean the PDK can't use these annotations, but at least it doesn't break it either.