(MAINT) bump ruby version #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Oct 2, 2022
chelnak
force-pushed
the
maint-bump-ruby-version
branch
3 times, most recently
from
9ee566c
to
a7fd9aa
Compare
ekohl
reviewed
Oct 3, 2022
chelnak
force-pushed
the
maint-bump-ruby-version
branch
3 times, most recently
from
f11dcaa
to
32dbd5e
Compare
|
FYI - I'm fully expecting the tests to be a sea of red here. This PR is one step in a series of clean up PRs. |
This commit bumps the minimum required ruby version to 2.5. It also contains some small cleanups. Mainly removal of older version constraints.
This commit adds rubocop config with the TargetRubyVersion set to 2.5.
chelnak
force-pushed
the
maint-bump-ruby-version
branch
from
32dbd5e
to
c6de3ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.