Update dependency_decisions for LicenseFinder 6.0; Fix deprecation warning with outdated win32-service gem pulled in by puppet #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
added
the
maintenance
DavidS
changed the title
DavidS
force-pushed
the
fix-license-finder
branch
from
23fc6ba
to
575104b
Compare
DavidS
changed the title
DavidS
force-pushed
the
fix-license-finder
branch
from
575104b
to
45c3481
Compare
DavidS
changed the title
DavidS
force-pushed
the
fix-license-finder
branch
from
be2f79d
to
9aab3f0
Compare
glennsarti
reviewed
Feb 3, 2020
| expect(stdout_str.strip).to match %r{\A(DL is deprecated, please use Fiddle\n)?#{expected_values}\Z} | ||
| fiddle_deprecate_msg = "DL is deprecated, please use Fiddle\n" | ||
| win32_deprecate_msg = ".*Struct layout is already defined for class Windows::ServiceStructs::SERVICE_STATUS_PROCESS.*\n" | ||
| expect(stdout_str.strip).to match %r{\A(#{fiddle_deprecate_msg}|#{win32_deprecate_msg})?#{expected_values}\Z} |
There was a problem hiding this comment.
Instead of matching the, probably fragile, warning methods, could you use a multi-line regex
e,g, (Not sure of the exact syntax)
expect(stdout_str.strip).to match %r{#{expected_values}/m}
9aab3f0
to
197a069
Compare
|
removed the last commit as travis support is reporting this is fixed on their side now. |
* remove obsolete `sudo` key * add `os: linux` default * make the cache directories arrays as requested by the schema * `matrix` -> `jobs` * some YAML reformatting
DavidS
force-pushed
the
fix-license-finder
branch
from
197a069
to
0abf7a0
Compare
michaeltlombardi
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pivotal/LicenseFinder#665 for reference