(PDK-882,PDK-883) validate only when needed #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `puppet resource` tries to find a specific resource, it only passes a hash with the title through. Puppet then calls validate, which fails, because the `ensure` property is mandatory. This change ignores a missing `:ensure` value if a call from `puppet resource` is detected. Added a bunch of acceptance-level tests to make sure that the `apply` case still works.
DavidS
force-pushed
the
pdk-882-fix-validation
branch
from
cfde586
to
e964d4a
Compare
When deleting resources, some validation has to be skipped. It does not make sense to check properties, but parameters still need to be checked.
DavidS
force-pushed
the
pdk-882-fix-validation
branch
from
e964d4a
to
e1ae67c
Compare
da-ar
reviewed
Mar 26, 2018
| expect(status.exitstatus).to eq 0 | ||
| end | ||
|
|
||
| it 'validates property' do |
There was a problem hiding this comment.
new test for 'A mandatory property, that MUST NOT be validated on deleting.
output, status = Open3.capture2e("puppet apply #{common_args} -e \"test_validation{ foo: ensure => absent, prop => not_a_number }\"")
expect(output.strip).to match %r{Test_validation\[foo\]/ensure: undefined 'ensure' from 'present'}
expect(status.exitstatus).to eq 0
There was a problem hiding this comment.
I'd rather add a bunch of unit tests. The acceptance tests were primarily for the @called_from_resource, which I didn't need for PDK-883 in the end.
da-ar
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.