Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out beaker and fixture tasks into separate files #234

Closed
wants to merge 2 commits into from

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Mar 12, 2018

This makes them easier to consume on their own without pulling in
everything. This also moves around the tests for those parts, and
adds smoke tests to make sure Rakefiles still load and process
correctly.

@DavidS DavidS force-pushed the refactor branch 2 times, most recently from beb5a21 to 72f5b69 Compare March 12, 2018 10:56
@DavidS
Copy link
Contributor Author

DavidS commented Mar 12, 2018

See puppetlabs/puppet-resource_api#35 for the reason to have this.

DavidS added a commit to DavidS/puppet-resource_api that referenced this pull request Mar 12, 2018
DavidS added a commit to DavidS/puppet-resource_api that referenced this pull request Mar 12, 2018
By pulling in puppetlabs_spec_helper into the main project, we can run
tests for the `test_module` in the main test suite without friction.
This makes it easier and quicker to run this kind of tests.

See the next commits for usage.

This requires puppetlabs/puppetlabs_spec_helper#234
@puppetcla
Copy link

CLA signed by all contributors.

DavidS added a commit to DavidS/puppet-resource_api that referenced this pull request Mar 13, 2018
By pulling in puppetlabs_spec_helper into the main project, we can run
tests for the `test_module` in the main test suite without friction.
This makes it easier and quicker to run this kind of tests.

See the next commits for usage.

This requires puppetlabs/puppetlabs_spec_helper#234
With the release of mocha 1.5.0 these two tests started failing. This
removes mocha from the test suite.
This makes them easier to consume on their own without pulling in
everything. This also moves around the tests for those parts, and
adds smoke tests to make sure Rakefiles still load and process
correctly.
@DavidS
Copy link
Contributor Author

DavidS commented Apr 6, 2018

This now depends on #236

@DavidS
Copy link
Contributor Author

DavidS commented Apr 6, 2018

Closing this temporarily to rename the source branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants