Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Add Plans Path Exclusion #270

Merged

Conversation

RandomNoun7
Copy link
Contributor

The Puppet parser cannot yet handle bolt plan syntax. Without this
exlusion adding plans to a module causes CI to fail in Appveyor because
the default lint checks will fail.

The Puppet parser cannot yet handle bolt plan syntax. Without this
exlusion adding plans to a module causes CI to fail in Appveyor because
the default lint checks will fail.
@RandomNoun7
Copy link
Contributor Author

RandomNoun7 commented Jan 10, 2019

This change is in coordination with a PR to the PDK templates, to ensure that modules that have plans don't need as many hand crafted changes to the template controlled files in the module after every PDK Update. puppetlabs/pdk-templates#176

@jpogran
Copy link
Contributor

jpogran commented Jan 10, 2019

This is pending #271

@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #270 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   44.37%   44.45%   +0.08%     
==========================================
  Files          11       11              
  Lines         773      776       +3     
==========================================
+ Hits          343      345       +2     
- Misses        430      431       +1
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/rake_tasks.rb 46.34% <100%> (+0.26%) ⬆️
...puppetlabs_spec_helper/puppetlabs_spec/matchers.rb 20.83% <0%> (-0.45%) ⬇️
lib/puppetlabs_spec_helper/tasks/check_symlinks.rb 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b98af8...516c1af. Read the comment docs.

@pmcmaw pmcmaw merged commit 3bc36ce into puppetlabs:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants