Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop outdated future parser support #348

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

binford2k
Copy link
Contributor

This is outdated and no longer supported by puppet-syntax

@binford2k binford2k requested review from a team as code owners February 15, 2022 18:40
@codecov-commenter
Copy link

Codecov Report

Merging #348 (5106954) into main (cbad6f4) will decrease coverage by 0.48%.
The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   43.28%   42.80%   -0.49%     
==========================================
  Files          11       10       -1     
  Lines         841      771      -70     
==========================================
- Hits          364      330      -34     
+ Misses        477      441      -36     
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/module_spec_helper.rb 0.00% <0.00%> (ø)
lib/puppetlabs_spec_helper/puppet_spec_helper.rb 65.51% <ø> (ø)
lib/puppetlabs_spec_helper/tasks/fixtures.rb 38.36% <ø> (ø)
lib/puppetlabs_spec_helper/rake_tasks.rb 42.50% <65.00%> (+1.03%) ⬆️
...bs_spec_helper/puppetlabs_spec/puppet_internals.rb 92.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aae63b...5106954. Read the comment docs.

Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Is that a breaking change? or di we say that such old puppet versions arent supported by latest puppetlabs_spec_helper anyways?

@binford2k
Copy link
Contributor Author

It would be a breaking change, except that we already accidentally broke when puppet-syntax released 3.0

This is outdated and no longer supported by [puppet-syntax](voxpupuli/puppet-syntax#120)
@chelnak
Copy link
Contributor

chelnak commented Oct 24, 2022

Thanks @binford2k

@chelnak chelnak merged commit d329e49 into puppetlabs:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants