Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) - check for empty fixtures array, as well as nil #435

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

jordanbreen28
Copy link
Contributor

Summary

Allows for an empty array to be specified for symlinks. May have broke existing setups like this.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 changed the title (bug) - check for empty fixtures array as well as nil (bug) - check for empty fixtures array, as well as nil Feb 9, 2024
@jordanbreen28 jordanbreen28 marked this pull request as ready for review February 9, 2024 08:54
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62b6f63) 41.71% compared to head (db10c85) 41.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files          10       10           
  Lines         676      676           
=======================================
  Hits          282      282           
  Misses        394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit e5e51a2 into main Feb 9, 2024
10 checks passed
@LukasAud LukasAud deleted the gh-397-honour_default_symlink branch February 9, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants